feat(variant): add kode dot ESP32-S3 board with QSPI LCD, SD and GPIO … #11371
+199
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello LusimiCollado, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
|
Hi @LusimiCollado, please move your board definitions in boards.txt file to the end of the list as it's your 1st board there, and also replace comments to be in English. Thanks |
|
Hi @P-R-O-C-H-Y, thanks for the review. I have change the board to be at the end, ensure all the need comments are in english and removed the not needed ones. Thanks for the review. |
me-no-dev
reviewed
May 19, 2025
me-no-dev
reviewed
May 19, 2025
P-R-O-C-H-Y
reviewed
May 19, 2025
|
Hi, @P-R-O-C-H-Y i have change description of the last 3 commits in order to meet Contribution Guidelines. So i think the pre-commit check process have stop. |
|
HI, @P-R-O-C-H-Y and @me-no-dev. Is any action needed from my side on this topic? Thanks in advance for the info. |
|
@LusimiCollado changes look OK. Have you managed to verify them with your board? |
Yes, i have try some esp32 examples on the board and my own code. |
me-no-dev
approved these changes
May 27, 2025
|
@P-R-O-C-H-Y PTAL and prep for merging if all is OK |
LusimiCollado
commented
May 27, 2025
|
@LusimiCollado please stop touching the PR. Merging master was not needed |
|
@LusimiCollado please fix the styling errors reported by CI: https://github.com/espressif/arduino-esp32/actions/runs/15272648860/job/42953247548?pr=11371#step:9:82 |
The "Allow Edits by managers" box is disabled and we can't apply the fixes automatically. Please fix it manually. |
lucasssvaz
added
the
Status: Awaiting Response
|
Hi, sorry for the delay. I have just correct the errors. @me-no-dev @lucasssvaz |
P-R-O-C-H-Y
added
Status: Pending Merge
|
@LusimiCollado You have missed some errors in pre-commit. Please fix them https://github.com/espressif/arduino-esp32/actions/runs/15875659287/job/44762512637?pr=11371#step:9:41 |
P-R-O-C-H-Y
added
Status: Awaiting Response
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kode dot esp32-s3 board variant
Description of Change
This PR adds full support for the kode dot esp32-s3 board variant to the Arduino-ESP32 core:
variants/kodedot/containing:pins_arduino.hwith pin mappings for the 2×10 header, QSPI-LCD, SD, I²C buses, buttons, NeoPixel, JTAG, USB power pins, etc.kodedot_partitions.csvdefining the custom flash layout (OTA, SPIFFS, app slots).custom_ota_override.cppto override the weakverifyRollbackLater()hook, forcing OTA images to remain un-validated until explicitly approved, thus protecting against faulty updates.platform.txt:esptool_py_nomergethat writes firmware at the partition offset defined inkodedot_partitions.csvwithout manual flags.boards.txt(board entry for KodeDot)platform.txt(custom tool declaration)With these additions, users can select kode dot, compile and upload their sketch (or OTA) directly into the correct partition, and rely on the
custom_ota_override.cppbehavior to guard against bad firmware rolls.Test scenarios
I have tested and debugged this PR on real kode dot hardware using:
LED_BUILTIN)esptool_py_nomergeAll tests passed, including OTA rollback verification.
Related links
boards.txt,platform.txt